Compare commits
3
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
4e0eb2f983 | ||
|
|
ab6ca1ebcf | ||
|
|
e01181959d |
No files matched your search
@@ -45,6 +45,24 @@ process_request(request(resolve, CaseRef, Domain, Roots, Question), Response) :-
|
|||||||
; Response = response(error, no_resolution, CaseRef)
|
; Response = response(error, no_resolution, CaseRef)
|
||||||
).
|
).
|
||||||
|
|
||||||
|
%% The challenge step of the dialectic, on its own (tablet 55: the
|
||||||
|
%% Sanhedrin's second seat asks it; until now no handler answered and
|
||||||
|
%% the socket fell silent). Interpret, then look for a kushya against
|
||||||
|
%% the interpretation: one stands → resolved_challenged, the kushya
|
||||||
|
%% named; none → no_challenge, the interpretation as read.
|
||||||
|
process_request(request(challenge, CaseRef, Domain, Roots, Question), Response) :-
|
||||||
|
Case = case(CaseRef, Domain, Roots, Question),
|
||||||
|
( interpret(Case, Interpretation)
|
||||||
|
-> ( challenge(Interpretation, Kushya)
|
||||||
|
-> Response = response(ok, resolved_challenged,
|
||||||
|
result(interpretation(Interpretation),
|
||||||
|
challenge(Kushya)))
|
||||||
|
; format_interpretation(Interpretation, response(ok, interpreted, Result)),
|
||||||
|
Response = response(ok, no_challenge, Result)
|
||||||
|
)
|
||||||
|
; Response = response(error, no_interpretation, CaseRef)
|
||||||
|
).
|
||||||
|
|
||||||
process_request(request(halt_check, Action), Response) :-
|
process_request(request(halt_check, Action), Response) :-
|
||||||
format_halt_check(Action, Response).
|
format_halt_check(Action, Response).
|
||||||
|
|
||||||
|
|||||||
@@ -153,11 +153,15 @@ read_coupling_term(Str, Term) :-
|
|||||||
%% JSON format (Construction §3.3):
|
%% JSON format (Construction §3.3):
|
||||||
%% { "status": "resolved", "interpretation": { ... } }
|
%% { "status": "resolved", "interpretation": { ... } }
|
||||||
|
|
||||||
%% Interpreted response
|
%% Interpreted response — and the same shape under the names the
|
||||||
response_to_json(response(ok, interpreted, result(ref(Ref), mitzvot(Mitzvot),
|
%% resolve and challenge steps give it when the reading stands
|
||||||
|
%% (tablet 55: resolved_accepted had no clause, so a resolve that
|
||||||
|
%% succeeded came back UNEXPECTED_RESPONSE; no_challenge is new).
|
||||||
|
response_to_json(response(ok, Kind, result(ref(Ref), mitzvot(Mitzvot),
|
||||||
verses(Verses), reading(Reading),
|
verses(Verses), reading(Reading),
|
||||||
confidence(Conf))),
|
confidence(Conf))),
|
||||||
Dict) :-
|
Dict) :-
|
||||||
|
memberchk(Kind, [interpreted, resolved_accepted, no_challenge]),
|
||||||
maplist(term_to_string, Mitzvot, MitzvotStrs),
|
maplist(term_to_string, Mitzvot, MitzvotStrs),
|
||||||
maplist(term_to_string, Verses, VerseStrs),
|
maplist(term_to_string, Verses, VerseStrs),
|
||||||
term_to_string(Reading, ReadingStr),
|
term_to_string(Reading, ReadingStr),
|
||||||
@@ -171,21 +175,52 @@ response_to_json(response(ok, interpreted, result(ref(Ref), mitzvot(Mitzvot),
|
|||||||
confidence: ConfStr},
|
confidence: ConfStr},
|
||||||
challenge: null}.
|
challenge: null}.
|
||||||
|
|
||||||
%% Challenged response
|
%% Challenged response — the interpretation's verses and mitzvot are
|
||||||
|
%% carried, so a judge rejecting on the kushya still cites its ground.
|
||||||
response_to_json(response(ok, resolved_challenged,
|
response_to_json(response(ok, resolved_challenged,
|
||||||
result(interpretation(Interp), challenge(Kushya))),
|
result(interpretation(Interp), challenge(Kushya))),
|
||||||
Dict) :-
|
Dict) :-
|
||||||
|
Interp = interpretation(_Ref, Mitzvot, Verses, _Reading, _Conf, _Trace),
|
||||||
|
maplist(term_to_string, Mitzvot, MitzvotStrs),
|
||||||
|
maplist(term_to_string, Verses, VerseStrs),
|
||||||
term_to_string(Interp, InterpStr),
|
term_to_string(Interp, InterpStr),
|
||||||
term_to_string(Kushya, KushyaStr),
|
term_to_string(Kushya, KushyaStr),
|
||||||
Dict = json{status: "challenged",
|
Dict = json{status: "challenged",
|
||||||
interpretation: json{text: InterpStr,
|
interpretation: json{text: InterpStr,
|
||||||
prolog_form: InterpStr,
|
prolog_form: InterpStr,
|
||||||
grounding: [],
|
grounding: MitzvotStrs,
|
||||||
|
verses: VerseStrs,
|
||||||
confidence: "medium"},
|
confidence: "medium"},
|
||||||
challenge: json{kushya: KushyaStr,
|
challenge: json{kushya: KushyaStr,
|
||||||
contradicting: "",
|
contradicting: "",
|
||||||
strength: "moderate"}}.
|
strength: "moderate"}}.
|
||||||
|
|
||||||
|
%% Synthesized resolution: both readings stand on common ground.
|
||||||
|
response_to_json(response(ok, resolved_synthesized,
|
||||||
|
result(common(Common), verses(Verses), both_sides(Both))),
|
||||||
|
Dict) :-
|
||||||
|
maplist(term_to_string, Common, CommonStrs),
|
||||||
|
maplist(term_to_string, Verses, VerseStrs),
|
||||||
|
term_to_string(Both, BothStr),
|
||||||
|
Dict = json{status: "resolved",
|
||||||
|
interpretation: json{text: BothStr,
|
||||||
|
prolog_form: BothStr,
|
||||||
|
grounding: CommonStrs,
|
||||||
|
verses: VerseStrs,
|
||||||
|
confidence: "medium"},
|
||||||
|
challenge: null}.
|
||||||
|
|
||||||
|
%% No interpretation possible (from resolve)
|
||||||
|
response_to_json(response(ok, no_interpretation, result(ref(Ref))), Dict) :-
|
||||||
|
atom_string(Ref, RefStr),
|
||||||
|
Dict = json{status: "teiku",
|
||||||
|
interpretation: json{text: "No interpretation found",
|
||||||
|
prolog_form: RefStr,
|
||||||
|
grounding: [],
|
||||||
|
verses: [],
|
||||||
|
confidence: "low"},
|
||||||
|
challenge: null}.
|
||||||
|
|
||||||
%% Teiku response
|
%% Teiku response
|
||||||
response_to_json(response(ok, teiku, result(record(Record))), Dict) :-
|
response_to_json(response(ok, teiku, result(record(Record))), Dict) :-
|
||||||
term_to_string(Record, RecordStr),
|
term_to_string(Record, RecordStr),
|
||||||
|
|||||||
@@ -112,3 +112,52 @@ test(teiku_count_works) :-
|
|||||||
integer(Count).
|
integer(Count).
|
||||||
|
|
||||||
:- end_tests(teiku_module).
|
:- end_tests(teiku_module).
|
||||||
|
|
||||||
|
%% ============================================================
|
||||||
|
%% Tablet 55 — the dialectic over the wire: interpret, challenge,
|
||||||
|
%% resolve each answer JSON a judge can vote on. Before this the
|
||||||
|
%% engine had no "challenge" action and a resolve that succeeded came
|
||||||
|
%% back UNEXPECTED_RESPONSE (resolved_accepted had no JSON clause).
|
||||||
|
%% ============================================================
|
||||||
|
|
||||||
|
:- use_module('../src/interface/api').
|
||||||
|
:- use_module('../src/interface/json_bridge').
|
||||||
|
:- use_module('../src/interface/socket_server').
|
||||||
|
|
||||||
|
:- begin_tests(dialectic_over_the_wire).
|
||||||
|
|
||||||
|
roots_line(Action, Line) :-
|
||||||
|
format(atom(Line),
|
||||||
|
'{"action":"~w","case":{"ref":"t55-~w","question":"q","context_roots":["bet-resh-aleph","aleph-lamed-he"]}}',
|
||||||
|
[Action, Action]).
|
||||||
|
|
||||||
|
test(interpret_answers_resolved_with_verses, [nondet]) :-
|
||||||
|
roots_line(interpret, L),
|
||||||
|
socket_server:process_json_line(L, R),
|
||||||
|
get_dict(status, R, "resolved"),
|
||||||
|
get_dict(interpretation, R, I),
|
||||||
|
get_dict(verses, I, Vs), Vs \== [].
|
||||||
|
|
||||||
|
test(challenge_answers_and_carries_the_ground, [nondet]) :-
|
||||||
|
roots_line(challenge, L),
|
||||||
|
socket_server:process_json_line(L, R),
|
||||||
|
get_dict(status, R, S),
|
||||||
|
memberchk(S, ["resolved", "challenged"]),
|
||||||
|
get_dict(interpretation, R, I),
|
||||||
|
get_dict(verses, I, Vs), Vs \== [].
|
||||||
|
|
||||||
|
test(resolve_answers_resolved_not_unexpected, [nondet]) :-
|
||||||
|
roots_line(resolve, L),
|
||||||
|
socket_server:process_json_line(L, R),
|
||||||
|
\+ get_dict(error, R, _),
|
||||||
|
get_dict(status, R, S),
|
||||||
|
memberchk(S, ["resolved", "challenged", "teiku"]).
|
||||||
|
|
||||||
|
test(no_roots_resolves_on_an_empty_trace, [nondet]) :-
|
||||||
|
socket_server:process_json_line('{"action":"interpret","case":{"ref":"t55-empty","question":"q","context_roots":[]}}', R),
|
||||||
|
get_dict(status, R, "resolved"),
|
||||||
|
get_dict(interpretation, R, I),
|
||||||
|
get_dict(verses, I, []),
|
||||||
|
get_dict(grounding, I, []).
|
||||||
|
|
||||||
|
:- end_tests(dialectic_over_the_wire).
|
||||||
@@ -63,8 +63,8 @@ defmodule VavPipeline.BereishitCycle do
|
|||||||
"""
|
"""
|
||||||
|
|
||||||
alias VavPipeline.{Specification, CycleLog, Manna, HaltConditions,
|
alias VavPipeline.{Specification, CycleLog, Manna, HaltConditions,
|
||||||
ShoreshEngineClient, TalmudicEngineClient, SanhedrinClient,
|
ShoreshEngineClient, TalmudicEngineClient, TalmudicEngineSocket,
|
||||||
Chatzotzrot}
|
SanhedrinClient, Chatzotzrot}
|
||||||
|
|
||||||
require Logger
|
require Logger
|
||||||
|
|
||||||
@@ -308,7 +308,11 @@ defmodule VavPipeline.BereishitCycle do
|
|||||||
final =
|
final =
|
||||||
case result do
|
case result do
|
||||||
{:ok, data} ->
|
{:ok, data} ->
|
||||||
check_halt_on_output(data)
|
# Every question is read against the engine, not only a teiku
|
||||||
|
# that never comes (2026-10-19: ki_tov returns teiku only on a
|
||||||
|
# root with no Hebrew, and the Shoresh Engine never leaves one;
|
||||||
|
# the Talmudic route had never been walked by a real question).
|
||||||
|
data |> consult_engine(context) |> check_halt_on_output()
|
||||||
|
|
||||||
{:unresolved, data} ->
|
{:unresolved, data} ->
|
||||||
case route_if_unresolved(data, context) do
|
case route_if_unresolved(data, context) do
|
||||||
@@ -325,6 +329,90 @@ defmodule VavPipeline.BereishitCycle do
|
|||||||
final
|
final
|
||||||
end
|
end
|
||||||
|
|
||||||
|
# ============================================================
|
||||||
|
# The engine, consulted on every resolved cycle
|
||||||
|
# ============================================================
|
||||||
|
|
||||||
|
# Architecture §3.3: the Talmudic Engine grounds a reading in verses
|
||||||
|
# and mitzvot over the case's roots. The cycle's own ki_tov says the
|
||||||
|
# roots stand in L1; the engine says what stands on them. Called
|
||||||
|
# directly on the socket — never the client's stub (tablet 41): an
|
||||||
|
# engine that cannot be reached is reported as not consulted, and the
|
||||||
|
# cycle's answer stands without it. A tamid probe does not consult
|
||||||
|
# (the fire is checked, the engine is not loaded by the check).
|
||||||
|
defp consult_engine(%{probe: true} = data, _context), do: data
|
||||||
|
|
||||||
|
defp consult_engine(data, _context) do
|
||||||
|
roots = Map.get(data, :roots_activated, [])
|
||||||
|
names = roots |> Enum.map(&engine_root_name/1) |> Enum.reject(&is_nil/1)
|
||||||
|
case_ref = Map.get(data, :case_ref, generate_case_ref())
|
||||||
|
|
||||||
|
cond do
|
||||||
|
names == [] ->
|
||||||
|
Map.put(data, :talmudic_consulted, {:skipped, :no_roots})
|
||||||
|
|
||||||
|
Process.whereis(TalmudicEngineSocket) == nil ->
|
||||||
|
Map.put(data, :talmudic_consulted, {:error, :engine_socket_not_started})
|
||||||
|
|
||||||
|
true ->
|
||||||
|
case TalmudicEngineSocket.interpret(case_ref, %{context_roots: names, question: Map.get(data, :raw, "")}) do
|
||||||
|
{:ok, %{"status" => _} = reply} ->
|
||||||
|
Map.merge(data, %{talmudic_interpretation: reply, talmudic_consulted: :ok})
|
||||||
|
|
||||||
|
{:ok, other} ->
|
||||||
|
Logger.warning("BereishitCycle: engine answered an unexpected shape for #{case_ref}: #{inspect(other)}")
|
||||||
|
Map.put(data, :talmudic_consulted, {:error, :unexpected_reply})
|
||||||
|
|
||||||
|
{:error, reason} ->
|
||||||
|
Logger.warning("BereishitCycle: engine not consulted for #{case_ref}: #{inspect(reason)}")
|
||||||
|
Map.put(data, :talmudic_consulted, {:error, reason})
|
||||||
|
end
|
||||||
|
end
|
||||||
|
end
|
||||||
|
|
||||||
|
@doc """
|
||||||
|
The engine's reading, said plainly: how many verses and mitzvot it
|
||||||
|
coupled to the roots, and which. `nil` when there is no reading.
|
||||||
|
"""
|
||||||
|
@spec engine_reading_text(map()) :: String.t() | nil
|
||||||
|
def engine_reading_text(data) do
|
||||||
|
case Map.get(data, :talmudic_interpretation) do
|
||||||
|
%{"interpretation" => interp} = reply when is_map(interp) ->
|
||||||
|
verses = interp |> Map.get("verses", []) |> List.wrap() |> Enum.map(&verse_ref_display/1) |> Enum.reject(&is_nil/1) |> Enum.uniq()
|
||||||
|
mitzvot = interp |> Map.get("grounding", []) |> List.wrap() |> Enum.map(&mitzvah_display/1) |> Enum.reject(&is_nil/1) |> Enum.uniq()
|
||||||
|
status = Map.get(reply, "status", "")
|
||||||
|
|
||||||
|
cond do
|
||||||
|
verses == [] and mitzvot == [] ->
|
||||||
|
"Talmudic Engine (#{status}): no verse or mitzvah is coupled to these roots."
|
||||||
|
|
||||||
|
true ->
|
||||||
|
v = if verses == [], do: "no verse", else: "#{length(verses)} verse(s): #{Enum.join(verses, ", ")}"
|
||||||
|
m = if mitzvot == [], do: "no mitzvah", else: "#{length(mitzvot)} mitzvah/mitzvot: #{Enum.join(mitzvot, ", ")}"
|
||||||
|
"Talmudic Engine (#{status}): #{v}; #{m}."
|
||||||
|
end
|
||||||
|
|
||||||
|
_ ->
|
||||||
|
nil
|
||||||
|
end
|
||||||
|
end
|
||||||
|
|
||||||
|
# "verse_ref(bereishit,1,1,'...')" / "verse(shemot,3,14)" → "Bereishit 1:1"
|
||||||
|
defp verse_ref_display(s) do
|
||||||
|
case Regex.run(~r/verse(?:_ref)?\((bereishit|shemot|vayikra|bamidbar|devarim)\s*,\s*(\d+)\s*,\s*(\d+)/, to_string(s)) do
|
||||||
|
[_, book, ch, vs] -> "#{String.capitalize(book)} #{ch}:#{vs}"
|
||||||
|
_ -> nil
|
||||||
|
end
|
||||||
|
end
|
||||||
|
|
||||||
|
# "mitzvah(1,positive,know_hashem,always)" → "know_hashem (1, positive)"
|
||||||
|
defp mitzvah_display(s) do
|
||||||
|
case Regex.run(~r/mitzvah\((\d+)\s*,\s*(\w+)\s*,\s*(\w+)/, to_string(s)) do
|
||||||
|
[_, id, kind, name] -> "#{name} (#{id}, #{kind})"
|
||||||
|
_ -> nil
|
||||||
|
end
|
||||||
|
end
|
||||||
|
|
||||||
# ============================================================
|
# ============================================================
|
||||||
# Compose — the answer and its sources, from the context
|
# Compose — the answer and its sources, from the context
|
||||||
# ============================================================
|
# ============================================================
|
||||||
@@ -385,15 +473,19 @@ defmodule VavPipeline.BereishitCycle do
|
|||||||
deliberation =
|
deliberation =
|
||||||
case Map.get(data, :resolution) do
|
case Map.get(data, :resolution) do
|
||||||
:talmudic ->
|
:talmudic ->
|
||||||
text = get_in(data, [:talmudic_interpretation, "interpretation", "text"]) || ""
|
" " <> (engine_reading_text(data) || "Talmudic Engine resolved the case.")
|
||||||
" Talmudic Engine: #{text}"
|
|
||||||
|
|
||||||
:sanhedrin ->
|
:sanhedrin ->
|
||||||
pos = get_in(data, [:sanhedrin_decision, :majority, :position]) || ""
|
pos = get_in(data, [:sanhedrin_decision, :majority, :position]) || ""
|
||||||
" Sanhedrin majority: #{pos}"
|
" Sanhedrin majority: #{pos}"
|
||||||
|
|
||||||
_ ->
|
_ ->
|
||||||
""
|
# Consulted after ki_tov (every resolved question), or not.
|
||||||
|
case {engine_reading_text(data), Map.get(data, :talmudic_consulted)} do
|
||||||
|
{text, _} when is_binary(text) -> " " <> text
|
||||||
|
{nil, {:error, reason}} -> " Talmudic Engine: not consulted (#{inspect(reason)})."
|
||||||
|
_ -> ""
|
||||||
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
"Roots activated in #{verse.ref}: #{Enum.join(root_lines, "; ")}." <>
|
"Roots activated in #{verse.ref}: #{Enum.join(root_lines, "; ")}." <>
|
||||||
@@ -426,10 +518,19 @@ defmodule VavPipeline.BereishitCycle do
|
|||||||
text: verse.text_hebrew
|
text: verse.text_hebrew
|
||||||
}
|
}
|
||||||
|
|
||||||
|
# The engine's verses as references a reader can follow ("Bereishit
|
||||||
|
# 1:3"), the engine's own form kept beside them; the scope verse is
|
||||||
|
# not repeated.
|
||||||
talmudic_verses =
|
talmudic_verses =
|
||||||
case get_in(data, [:talmudic_interpretation, "interpretation", "verses"]) do
|
case get_in(data, [:talmudic_interpretation, "interpretation", "verses"]) do
|
||||||
vs when is_list(vs) -> Enum.map(vs, fn v -> %{ref: to_string(v)} end)
|
vs when is_list(vs) ->
|
||||||
_ -> []
|
vs
|
||||||
|
|> Enum.map(fn v -> %{ref: verse_ref_display(v) || to_string(v), engine_form: to_string(v)} end)
|
||||||
|
|> Enum.uniq_by(& &1.ref)
|
||||||
|
|> Enum.reject(&(&1.ref == verse.ref))
|
||||||
|
|
||||||
|
_ ->
|
||||||
|
[]
|
||||||
end
|
end
|
||||||
|
|
||||||
[primary | talmudic_verses]
|
[primary | talmudic_verses]
|
||||||
@@ -604,13 +705,22 @@ defmodule VavPipeline.BereishitCycle do
|
|||||||
{:interpretation, attrs, nil}
|
{:interpretation, attrs, nil}
|
||||||
|
|
||||||
_ ->
|
_ ->
|
||||||
|
# The engine's reading, when it was consulted, rides in the record:
|
||||||
|
# its verses beside the scope, its text in the reasoning, and the
|
||||||
|
# component names both readers.
|
||||||
|
interp = get_in(data, [:talmudic_interpretation, "interpretation"]) || %{}
|
||||||
|
engine_verses = interp |> Map.get("verses", []) |> to_string_list()
|
||||||
|
reading = engine_reading_text(data)
|
||||||
|
|
||||||
attrs =
|
attrs =
|
||||||
Map.merge(base, %{
|
Map.merge(base, %{
|
||||||
reasoning: single_judge_reasoning(data, context),
|
reasoning:
|
||||||
|
if(reading, do: single_judge_reasoning(data, context) <> " " <> reading, else: single_judge_reasoning(data, context)),
|
||||||
|
torah_references: Enum.uniq([scope_ref | engine_verses]),
|
||||||
panel_size: 1,
|
panel_size: 1,
|
||||||
vote_count_for: 1,
|
vote_count_for: 1,
|
||||||
vote_count_against: 0,
|
vote_count_against: 0,
|
||||||
processing_component: "bereishit_cycle"
|
processing_component: if(reading, do: "bereishit_cycle+talmudic_engine", else: "bereishit_cycle")
|
||||||
})
|
})
|
||||||
|
|
||||||
{:interpretation, attrs, nil}
|
{:interpretation, attrs, nil}
|
||||||
@@ -740,7 +850,10 @@ defmodule VavPipeline.BereishitCycle do
|
|||||||
@doc false
|
@doc false
|
||||||
defp route_if_unresolved(data, context) do
|
defp route_if_unresolved(data, context) do
|
||||||
roots = Map.get(data, :roots_activated, [])
|
roots = Map.get(data, :roots_activated, [])
|
||||||
context_roots = Enum.map(roots, & &1.shoresh)
|
# Tablet 55: the engine names roots by letter (bet_resh_aleph); the
|
||||||
|
# Hebrew was sent since Step 14 and never matched a verse fact, so
|
||||||
|
# every Talmudic interpretation was "resolved" over an empty trace.
|
||||||
|
context_roots = roots |> Enum.map(&engine_root_name/1) |> Enum.reject(&is_nil/1)
|
||||||
|
|
||||||
case_ref = Map.get(data, :case_ref, generate_case_ref())
|
case_ref = Map.get(data, :case_ref, generate_case_ref())
|
||||||
|
|
||||||
|
|||||||
Reference in new issue
Block a user